veg/tmux-party
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

refactor: drop eval from pick_live_party

Browse source 
Select the chosen positional argument with shift + "$1" instead of
building a $pick-indexed variable reference through eval.
This commit is contained in:
veg 2026-09-21 09:42:19 +00:00
parent c28101e2e8
commit bdcad47147
1 changed files with 2 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

3
party
View file

@ -668,7 +668,8 @@ pick_live_party() {
if [ "$pick" -lt 1 ] || [ "$pick" -gt $# ]; then if [ "$pick" -lt 1 ] || [ "$pick" -gt $# ]; then
echo "party: out of range" >&2; return 1 echo "party: out of range" >&2; return 1
fi fi
eval "roster_read \"\$$pick\"" shift $((pick - 1))
roster_read "$1"
} }
# Resolve the party a join or knock targets: the named party if given, # Resolve the party a join or knock targets: the named party if given,